D21915: Fix crash in the touchpad kded
Atul Bisht
noreply at phabricator.kde.org
Fri Jun 21 09:56:13 BST 2019
atulbi added a comment.
In D21915#482877 <https://phabricator.kde.org/D21915#482877>, @aacid wrote:
> In D21915#482182 <https://phabricator.kde.org/D21915#482182>, @knambiar wrote:
>
> > In D21915#482145 <https://phabricator.kde.org/D21915#482145>, @aacid wrote:
> >
> > > The other question is if "enabled" was ever the correct atom to check for
> > >
> > > libinput Tapping Enabled
> >
> >
> > I'm fairly sure we were checking for `libinput Tapping Enabled` atom in the past, and so does GNOME: https://gitlab.gnome.org/GNOME/gtk/blob/master/gdk/x11/gdkdevicemanager-xi2.c#L410
>
>
> I can't find any use of that, the current use of "enabled" was added by @atulbi
Whoops... It should be "libinput Send Events Mode Enabled" or LIBINPUT_PROP_SENDEVENTS_ENABLED rather than enabled. my bad ;) , Just replacing "enabled" fixes the issue :D
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D21915
To: aacid
Cc: atulbi, knambiar, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190621/2f1c27ba/attachment-0001.html>
More information about the Plasma-devel
mailing list