D21934: Ensure no one but us writes to stdout

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> connection.cpp:39
> +    int newStdout = dup(STDOUT_FILENO);
> +    close(STDOUT_FILENO);
> +    m_stdOut.open(newStdout, QIODevice::WriteOnly);

I'd `dup2(STDERR_FILENO, STDOUT_FILENO);` instead to ensure that if something tries to write to it or query something, there aren't unexpected errors.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21934

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190620/cb1c3ced/attachment-0001.html>