D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> KeyboardButton.qml:10
>  PlasmaComponents.ToolButton {
> -    id: keyboardButton
> +    id: toolBtn
>  

Prefer descriptive variable names; `toolButton` is better than `toolBtn`, but even better would be a description of what this button is actually for. The original was better and didn't need to be changed IMO.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190620/8bf5c117/attachment.html>