D21895: print a warning when invoking the scripting API's sleep()

Harald Sitter noreply at phabricator.kde.org
Wed Jun 19 10:40:50 BST 2019


sitter created this revision.
sitter added a reviewer: mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  the sleep is implemented with a nested event loop which may result in
  segfaults when something in the new loop stack accesses objects from the
  original loop stack that are presently in a bad state because they were
  not meant to be accessed (and only can because of the nesting).
  
  to aid in debugging let's leave a trace of the fact that sleep was used
  when in fact, using sleep is super risky.

TEST PLAN
  warning gets printed when sleeping

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21895

AFFECTED FILES
  shell/scripting/appinterface.cpp

To: sitter, mart
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190619/7ed26f3d/attachment.html>


More information about the Plasma-devel mailing list