D21829: Improved Touch support for Kickoff

David Edmundson noreply at phabricator.kde.org
Tue Jun 18 18:57:53 BST 2019


davidedmundson added inline comments.

INLINE COMMENTS

> KickoffListView.qml:142
> +                        if (item.appView) {
> +                            if (mouse.source == Qt.MouseEventSynthesizedByQt) {
> +                                positionChanged(mouse);

why do we need this?

> KickoffListView.qml:204
> +                     if (mouse.source == Qt.MouseEventSynthesizedByQt) {
> +                        tapandhold = true;
> +                        positionChanged(mouse);

we tend to useCamelCaseForVariables

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff

REVISION DETAIL
  https://phabricator.kde.org/D21829

To: steffenh, #plasma, hein, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190618/614200bc/attachment-0001.html>


More information about the Plasma-devel mailing list