D21881: [Notifications] Read BAMF_DESKTOP_FILE_HINT from environment
Kai Uwe Broulik
noreply at phabricator.kde.org
Tue Jun 18 14:23:39 BST 2019
broulik created this revision.
broulik added reviewers: Plasma, sitter.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
This is a similar situation we have with Flatpak when the desktop entry the application thinks it owns is actually different.
In Snap this environment variable is passed to the process. When no service was found, try reading it.
TEST PLAN
5.16 branch
My Spotify snap now identifies as Spotify and I can configure notifications for it.
F6907051: Screenshot_20190618_150619.png <https://phabricator.kde.org/F6907051>
- Notification without app name still resolves to process name properly
- Service lookup for normal apps still works
- Job view without an app name still resolves to process name properly
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D21881
AFFECTED FILES
libnotificationmanager/jobsmodel_p.cpp
libnotificationmanager/notification.cpp
libnotificationmanager/notification.h
libnotificationmanager/notification_p.h
libnotificationmanager/server_p.cpp
libnotificationmanager/utils.cpp
libnotificationmanager/utils_p.h
To: broulik, #plasma, sitter
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190618/41996c54/attachment.html>
More information about the Plasma-devel
mailing list