D21829: Improved Touch support for Kickoff

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Very nice. You're becoming quite the expert on touch gestures in KDE software! :)
  
  This works great on my touchscreen, and I did not find any regressions when using my touchpad or mouse. The diff is surprisingly small and seems sane to me. If you could work on the icon not following the cursor when dragged, that would be great, but from my perspective this is a ship-it as-is since it's a big improvement already. I'm giving it an "Approved" now and I'll bring it up to the Plasma folks at the Plasma spring that starts in three days.

INLINE COMMENTS

> KickoffListView.qml:199
> +                        tapandhold = true;
> +                         positionChanged(mouse);
> +                     }

remove extra leading space here

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff

REVISION DETAIL
  https://phabricator.kde.org/D21829

To: steffenh, #plasma, hein, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190617/29a83a84/attachment-0001.html>