D21856: [Task manager] Use consistent menu items for "pin/unpin" actions

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Make the pinning-relatedmenu items consistent by showing separate Pin and Unpin menu
  items when not using activities. When using activities, it's unavoidable, so we still
  show a more complicated UI there with checkboxes for the per-activity pinning options.
  
  BUG: 395615
  FIXED-IN: 5.17.0

TEST PLAN
  Right-click on pinned launchers, open unpinned tasks, and open pinned tasks - see that all have the correct menu items
  
  Do it again with mode than one Activity and see that all is still well

REPOSITORY
  R119 Plasma Desktop

BRANCH
  consistify-pin-unpin-menu-items (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21856

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml

To: ngraham, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190616/e7da0d35/attachment.html>