D21815: [sddm-theme] Start moving from QQC1 to QQC2

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> SessionButton.qml:23
>  import org.kde.plasma.core 2.0 as PlasmaCore
>  import org.kde.plasma.components 2.0 as PlasmaComponents
>  

Note that (confusingly) Plasma components 2 is QQC1
Plasma components3 is QQC2

It might fix the menu issue

> SessionButton.qml:29
>      id: root
> -    property int currentIndex: -1
> +    implicitWidth: width
> +    height: toolBtn.implicitHeight

I meant

implicitWidth: toolBtn.implicitWidth

width by default is bound to the implicitWidth so you don't need to set it
but more importantly you still have the data of the size something wants to be after someone else (a layout) sets the size

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190615/c94b2bad/attachment.html>