D21828: Invert controls direction for process priority slider
Kishore Gopalakrishnan
noreply at phabricator.kde.org
Sat Jun 15 11:04:42 BST 2019
kishoreg created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kishoreg requested review of this revision.
REVISION SUMMARY
Since low 'nice' values correspond to high priority, the slider labels are inverted so that 'higher' corresponds to a lower nice number. However, this was not done for the slider control, resulting in the arrow keys moving the slider in the direction opposite to that expected by the user. This patch fixes this by setting invertedControls to 'true' for the priority slider.
BUG: 408074
TEST PLAN
1. Open Ksysguard.
2. Go to the tab that lists processes.
3. Right click on a process and select 'Set Priority'.
4. Click on the slider that sets the CPU priority.
5. Press the left and right arrow keys on the keyboard and check if they move the slider in the appropriate direction.
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D21828
AFFECTED FILES
processui/ReniceDlgUi.ui
To: kishoreg
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190615/c4ee2475/attachment.html>
More information about the Plasma-devel
mailing list