D21815: [sddm-theme] Start moving from QQC1 to QQC2

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Concept makes sense, minor tweaks above
  
  Make sure you  test in full sddm, the test mode will infer some settings from your session which won't be valid in real usage.

INLINE COMMENTS

> KeyboardButton.qml:23
>  
> -    menu: QQC.Menu {
> +//         menu: QQC.Menu {
> +//             id: keyboardMenu

Please fix.

> SessionButton.qml:27
>  
> -PlasmaComponents.ToolButton {
> +Item {
>      id: root

Why the wrapper?

> SessionButton.qml:29
>      id: root
> -    property int currentIndex: -1
> +    height: toolBtn.height
> +    width: toolBtn.width

Implicit height should be propagated upwards, not height.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190615/e9f52098/attachment-0001.html>