D21811: [Calculator] Fix popup size and minimum size for expanded version

Nathaniel Graham noreply at phabricator.kde.org
Fri Jun 14 22:45:53 BST 2019


ngraham created this revision.
ngraham added reviewers: davidedmundson, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  In D21503 <https://phabricator.kde.org/D21503>, I messed up the popup size and made it iconify at too small a size. This
  patch aims to fix that.

TEST PLAN
  I'm not super familiar with this code so I'm not sure it's the right approach, but
  it does seem to work:
  
  F6890392: Pop-up.png <https://phabricator.kde.org/F6890392> 
  F6890391: Iconified large size.png <https://phabricator.kde.org/F6890391>

REPOSITORY
  R114 Plasma Addons

BRANCH
  fix-calculator-popup (branched from Plasma/5.16)

REVISION DETAIL
  https://phabricator.kde.org/D21811

AFFECTED FILES
  applets/calculator/package/contents/ui/calculator.qml

To: ngraham, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190614/b58e7a42/attachment.html>


More information about the Plasma-devel mailing list