D21794: Style the session selector to be more Breeze

[Filip Fila]

filipf added a comment.


  Thanks for the new version, almost there.

INLINE COMMENTS

> KeyboardButton.qml:25
> +        style: QQCS.MenuStyle {
> +            frame: Rectangle {
> +                color: PlasmaCore.ColorScope.backgroundColor

One more thing that I realized is missing here and that would make everything look like the desktop menus is a 1px border.

Now the stolen code should sort of look like this:

  property color borderColor: PlasmaCore.ColorScope.textColor
  border.color: Qt.rgba(borderColor.r, borderColor.g, borderColor.b, 0.3)
  border.width: 1

Unfortunately for some reason rgba fails when using dark themes and the border just turns white. Maybe you could figure out something better, but if you get stuck it's not super important.

> KeyboardButton.qml:39
> +                visible: styleData.selected
> +                color: "#3daee9"
> +            }

We still need to remove this bit of hardcoding:

`color: PlasmaCore.ColorScope.highlightColor`

and in the other file as well, of course.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21794

To: cblack, #vdg, filipf
Cc: apol, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190614/7fd159ed/attachment-0001.html>