D21799: actually set kaboutdata as application aboutdata

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Fri Jun 14 13:13:35 BST 2019


kossebau added inline comments.

INLINE COMMENTS

> main.cpp:89
>                           QStringLiteral("spehr at kde.org"));
> +    KAboutData::setApplicationData(aboutData);
>      qa.setWindowIcon(QIcon::fromTheme(QStringLiteral("tools-report-bug"), qa.windowIcon()));

This is partially redundant though with all the QCoreApplication::set* above, as well as qa.setDesktopFileName below. Those should be removed then for clean code.

REPOSITORY
  R871 DrKonqi

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21799

To: sitter, #plasma, davidedmundson
Cc: kossebau, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190614/f20a9c48/attachment.html>


More information about the Plasma-devel mailing list