D21762: do not use long deprecated QString::toAscii

Aleix Pol Gonzalez noreply at phabricator.kde.org
Wed Jun 12 13:02:33 BST 2019


apol added inline comments.

INLINE COMMENTS

> waylandtasksmodel.cpp:350
>      // cross-process DND.
> -    return QString("windowsystem/winid+" + uuid.toString().toAscii());
> +    return QString("windowsystem/winid+" + uuid.toString().toLatin1());
>  }

It's using weird API we shouldn't be using. It's creating a QString after all so I'd do:
`    return QStringLiteral("windowsystem/winid+") + uuid.toString();`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21762

To: sitter, hein
Cc: apol, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190612/cc9f73b2/attachment.html>


More information about the Plasma-devel mailing list