D21701: [kcm-colors] Do not ship any additional color schemes

Filip Fila noreply at phabricator.kde.org
Mon Jun 10 15:54:33 BST 2019


filipf added a comment.


  The first time I compiled this I actually forgot to clean up the `color-schemes` folder and nothing happened, the patch didn't delete the old schemes. That's why I concluded it would only be relevant for new installs. I will check again though.
  
  In D21701#477368 <https://phabricator.kde.org/D21701#477368>, @ngraham wrote:
  
  > +1 in principle.
  >
  > I think two things need to happen before we do this:
  >
  > 1. We need to upload the old ones to store.kde.org, preferably under a shared VDG account so that they can't just randomly go away if whoever uploads it leaves KDE or deletes their account or something
  > 2. The preview should show the active titlebar color or else it's really not at all obvious what the difference is between Breeze and Breeze dark. This is a pre-existing problem, but it would become worse when there are only four color schemes shipped by default and two of them have a preview image that looks identical.
  
  
  Yeah, uploading to the KDE store is a must.
  
  I'll try to whip up a patch for the previews to show titlebars then.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21701

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, davidedmundson, nicolasfella, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190610/1f8d641d/attachment.html>


More information about the Plasma-devel mailing list