D21646: re-read color palettes when application color changes
Sebastian Kügler
noreply at phabricator.kde.org
Fri Jun 7 12:38:57 BST 2019
sebas created this revision.
sebas added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sebas requested review of this revision.
REVISION SUMMARY
Without this patch, changing the application color scheme from system
settings only affects some widgets. Notably, checkboxes highlighting
colors stays the old color, leading to a hodge-podge color scheme and
bad contrast on some items.
The breeze QStyle caches the colors read via KSharedConfig, so it needs
to re-read the configuration when the application color changes.
QApplication emits an event (originating in KGlobalSettings), which we
can react to.
This fixes the coloring of various widgets in breeze right after color
changes.
BUG:408416
FIXED-IN: 5.15.6
TEST PLAN
1. open kcmshell5 colors
2. change to a theme with a different highlight color
3. apply
4. without patch: checkbox in color KCM (and a whole lot of other widgets all over the place) don't change colors
5. with patch: colors change as expected
REPOSITORY
R31 Breeze
BRANCH
colorchangeeventfilter
REVISION DETAIL
https://phabricator.kde.org/D21646
AFFECTED FILES
kstyle/breezestyle.cpp
kstyle/breezestyle.h
To: sebas, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190607/d16799f3/attachment-0001.html>
More information about the Plasma-devel
mailing list