D21642: use even more resizing
Harald Sitter
noreply at phabricator.kde.org
Fri Jun 7 11:47:07 BST 2019
sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.
REVISION SUMMARY
since the widget by default has no strings in the designer ui file any
state change injects stuff in qlabels and changes the effective size hint.
to deal with this once and for all the three state changes now always
call a new adjustment helper.
the adjustment helper calls adjustSize iff the hintted dimensions are
larger than the effective one. this way we don't shrink the window
when the backtrace is reloaded, but always grow it if needed for the
backtraced state.
CHANGELOG: The Developer Information tab now correctly resizes to fit the content
FIXED-IN: 5.16.1
BUG: 406748
TEST PLAN
- no cut off widgets when going to dev info tab while bt is generated
- neither when the bt is loaded
- doesn't shrink when clicking reload
REPOSITORY
R871 DrKonqi
BRANCH
Plasma/5.16
REVISION DETAIL
https://phabricator.kde.org/D21642
AFFECTED FILES
src/backtracewidget.cpp
src/backtracewidget.h
To: sitter
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190607/16aba6be/attachment.html>
More information about the Plasma-devel
mailing list