D21629: [Task Manager] Use ToolButtons for buttons in popup, rather than mouseArea+icon
Nathaniel Graham
noreply at phabricator.kde.org
Thu Jun 6 18:06:58 BST 2019
ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Right now, the Task Manager's popup has various buttons in it that do not look or
feel like buttons because they are implemented as a MouseArea with an Icon inside.
This patch makes them feel like standard buttons uses elsewhere by implementing
them using ToolButtons instead.
TEST PLAN
F6874640: ToolButtons for window closing controls.png <https://phabricator.kde.org/F6874640>
F6874639: ToolButtons for player controls.png <https://phabricator.kde.org/F6874639>
REPOSITORY
R119 Plasma Desktop
BRANCH
use-toolbuttons-in-popup-delegates (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D21629
AFFECTED FILES
applets/taskmanager/package/contents/ui/ToolTipInstance.qml
To: ngraham, #plasma, #vdg
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190606/bed7a339/attachment.html>
More information about the Plasma-devel
mailing list