D21610: Redesign Advanced tab

[Nathaniel Graham]

ngraham added a comment.


  Ah you're right, that's a pre-existing issue. However it does get worse with this redesign since the Advanced page is now much more compact. Oh well.
  
  I've found one new issue: when auto-login is enabled and you go to the Advanced page, its checkbox is checked but none of the related controls are un-disabled: F6874337: Screenshot_20190606_071356.png <https://phabricator.kde.org/F6874337>
  
  When you toggle it off and on again, they do get enabled as expected. An inline comment explains why:

INLINE COMMENTS

> advanceconfig.ui:247
> +   <sender>autoLogin</sender>
> +   <signal>clicked(bool)</signal>
> +   <receiver>label_4</receiver>

This and other subsequent connections are probably the problem. The signal is only getting passed along when the checkbox is actually clicked. But nothing is connected to its `checked()` signal, so it doesn't know to enable the controls when the checkbox starts out checked but is not explicitly clicked by the user.

You can probably change `clicked` to `checked`.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21610

To: filipf, ngraham, #vdg, davidedmundson
Cc: abetts, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190606/2d30a480/attachment.html>