D21605: Don't give up if no results arrive after 500ms

Fabian Vogt noreply at phabricator.kde.org
Wed Jun 5 15:59:09 BST 2019


fvogt created this revision.
fvogt added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
fvogt requested review of this revision.

REVISION SUMMARY
  Currently it resets the entire context if no results appear after 500ms,
  which means no new results can appear. This makes no sense.
  
  RunnerManager does not emit any matchChanged signal while the runners update
  the matches too quickly. The way this delay is implemented can result in never
  actually emitting the signal until all runners are done though.
  Thus it's actually likely to hit this situation.
  
  BUG: 389611

TEST PLAN
  Test results appear now, even if the first batch of runners is slow.
  List of matches still clears if nothing was found.

REPOSITORY
  R112 Milou

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D21605

AFFECTED FILES
  lib/sourcesmodel.cpp
  lib/sourcesmodel.h

To: fvogt, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190605/742466a7/attachment.html>


More information about the Plasma-devel mailing list