D20908: RFC: Redesign QML applet configuration windows

[Marco Martin]

mart added a comment.


  This is the rough patch which gives a rough implementation of this look into qwidget config dialogs
  F6866217: fullsidebar.diff <https://phabricator.kde.org/F6866217>
  
  The real hack which I consider a no-go (and no idea how to avoid) is this piece:
  
  - layout->addWidget(mButtonBox);
  
  +            if (mPageWidget && mPageWidget->layout()) {
  +                mButtonBox->setParent(mPageWidget);
  +                static_cast<QGridLayout*>(mPageWidget->layout())->addWidget(mButtonBox, 4, 1);
  +            } else {
  +                layout->addWidget(mButtonBox);
  +            }
  
  it reparents the buttonbox inside the pagewidget itself to have the buttons laid out considering the sidebar.
  This will break badly and possibily crash in many situations, so ideas for alternative implementations welcome :D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, ericadams, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190603/610131a7/attachment-0001.html>