D21545: Make the Trashcan applet use the same shadow settings as desktop icons

Filip Fila noreply at phabricator.kde.org
Sun Jun 2 18:34:42 BST 2019


filipf added inline comments.

INLINE COMMENTS

> main.qml:154
>          }
> +        width: Math.round(text.implicitWidth + units.smallSpacing) // make sure label is not blurry
>          text: (dirModel.count === 0) ? i18n("Trash\nEmpty") : i18np("Trash\nOne item", "Trash\n %1 items", dirModel.count)

Should I copy all of the code from `FolderItemDelegate.qml`? It's:

`width: Math.round(Math.min(label.implicitWidth + units.smallSpacing, parent.width - units.smallSpacing))`

REPOSITORY
  R119 Plasma Desktop

BRANCH
  trashcan-consistent-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21545

To: filipf, #plasma, #vdg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190602/68eafba1/attachment-0001.html>


More information about the Plasma-devel mailing list