D21527: Fix the 'Report bug' button being always disabled
Daniel Vrátil
noreply at phabricator.kde.org
Sat Jun 1 23:25:36 BST 2019
dvratil created this revision.
dvratil added a reviewer: dfaure.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dvratil requested review of this revision.
REVISION SUMMARY
The commit d4ae04a7 <https://phabricator.kde.org/R871:d4ae04a78d0e22f1f142118509bcd2297ba8eb24> has changed #define of HAVE_XMLRPCLCIENT
to #cmakedefine01 - since HAVE_XMLRPCCLIENT is not defined anywhere
in the CMakeFiles.txt, this lead to the 'Report bug' button being
unconditionally disabled at compile time.
Since KXmlRpcClient is a REQUIRED dependency (and has been for a while),
we can just remove the macro altogether.
BUG: 406606
FIXED-IN: 5.16.0
CCMAIL: faure at kde.org
TEST PLAN
The 'Report bug' button is enabled
REPOSITORY
R871 DrKonqi
BRANCH
Plasma/5.16
REVISION DETAIL
https://phabricator.kde.org/D21527
AFFECTED FILES
src/config-drkonqi.h.cmake
src/drkonqidialog.cpp
To: dvratil, dfaure
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190601/317b175e/attachment.html>
More information about the Plasma-devel
mailing list