D22851: [SplitterProxy] Don't manually mapToGlobal

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Jul 31 12:19:23 BST 2019


broulik created this revision.
broulik added reviewers: Plasma, hpereiradacosta.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The constructor of `QMouseEvent` actually expects `windowPos` and/or `screenPos` but never `globalPos`.
  By only supplying a `localPos` we have Qt figure it out correctly on its own.

TEST PLAN
  - I can now drag the vertical splitter in QtCreator on my second 4k monitor, previously it would just snap to its leftmost position once I started moving, as the mapped coordinates became negative
  - I still have the enlarged splitter drag area provided by Breeze compared to e.g. Fusion style

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22851

AFFECTED FILES
  kstyle/breezesplitterproxy.cpp

To: broulik, #plasma, hpereiradacosta
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190731/6d5c0d6f/attachment.html>


More information about the Plasma-devel mailing list