D22832: Fix build with pango 1.44

Antonio Rojas noreply at phabricator.kde.org
Wed Jul 31 06:41:59 BST 2019


arojas added a comment.


  In D22832#504428 <https://phabricator.kde.org/D22832#504428>, @sitter wrote:
  
  > Shouldn't this somehow be handled via pkg-config? IIRC .pc files can indicate dependencies, so I would assume one could get the requirements somehow and resolve those using generic code instead of essentially replicating the dependency information in cmake.
  
  
  'pkgconf --cflags gtk+-3.0' and 'pkgconf --libs gtk+-3.0' will recursively return all required cflags and ldflags. But it doesn't look like this is exposed in cmake's pkg_check_modules - this just returns the first-level dependencies.
  
  Anyhow, this is just a hotfix to make the current FindGTK3 work with the latest release of pango. Any further changes towards simplifying it should go in a different commit IMO.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D22832

To: arojas, #plasma
Cc: apol, sitter, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190731/a0812c53/attachment.html>


More information about the Plasma-devel mailing list