D22817: Port KRunner to Plasma Components 3

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Jul 30 19:35:43 BST 2019


apol added inline comments.

INLINE COMMENTS

> broulik wrote in RunCommand.qml:56
> Why?

The button's height is by default really big and krunner then looks rather comical.
Here we're making sure it all stays as big as the text field after all.

> broulik wrote in RunCommand.qml:226
> Why remove this? It breaks highlighting of history items.

PC3 has no moving hightlight delegate, it's the delegate that highlights itself.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22817

To: apol, #plasma, broulik
Cc: ognarb, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190730/1b334221/attachment.html>


More information about the Plasma-devel mailing list