D22804: [System Tray] Do not send ContextMenu signal twice

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Jul 29 13:58:03 BST 2019


broulik added a comment.


  > Yes, probably onPressed should be handled in PasmoidItem, not in the AbstractItem to avoid this kind of problems.
  
  Indeed, that would be the best solution.
  
  > I would personally opt for consistency, though. As far as I know GTK is showing context menu on mouse click, not pressed. The same is for MS Windows (this does not mean we must follow this or reimplement Windows, no). What is your opinion?
  
  Gimp, Firefox, Chrome, Gedit, etc, they open it on press here, and so does Qt and the rest of KDE software, so this must be consistent to here, regardless of what someone else does.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22804

To: kmaterka, #plasma_workspaces
Cc: broulik, apol, plasma-devel, #plasma_workspaces, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190729/99128895/attachment.html>


More information about the Plasma-devel mailing list