D22804: [System Tray] Do not send ContextMenu signal twice

[Konrad Materka]

kmaterka created this revision.
kmaterka added a reviewer: Plasma: Workspaces.
kmaterka added a project: Plasma: Workspaces.
Herald edited projects, added Plasma; removed Plasma: Workspaces.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  System Tray sends two "ContextMenu" events which breaks focus.
  One is send on mouse pressed, second on mouse clicked. As a result
  right click on the system tray icon causes focus to lock on the icon.
  If later user clicks somewhere else event is send to the first icon.
  
  BUG: 376277
  BUG: 409649

TEST PLAN
  The best to test with Skype for Linux with SNI bridge.
  
  To reproduce:
  
  - Right click on the Skype icon, click on menu item (can be Show Skype)
  - Right click on any other icon in system tray (or even any other place on the panel)
  - Skype menu will appear
  
  After fix:
  
  - Right click on the Skype icon, click on menu item (can be Show Skype)
  - Right click on any other icon in system tray (or even any other place on the panel)
  - Correct menu should show

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22804

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml

To: kmaterka, #plasma_workspaces
Cc: plasma-devel, #plasma_workspaces, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190729/784d7a69/attachment.html>