D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe added inline comments.

INLINE COMMENTS

> ngraham wrote in potdprovider.cpp:54
> The lack of error handling and else blocks for all the ifs in this new code makes me feel a bit nervous.

Read Qt documentation that `QVariant::toString()` will always return a string even if the type is not supported (empty string). So this code won't produce any error/exception.

> ngraham wrote in config.qml:208
> Since this is only used once, you don't need to make it a function; just put all of this stuff in the `Component.onCompleted:` directly

Fixed.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190727/635f6508/attachment.html>