D22752: [kcms/fonts] Replace warning message with inline message when applying changes

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> main.qml:46
>  
> -        FontWidget {
> -            id: generalFontWidget
> -            label: i18n("General:")
> -            category: "generalFont"
> -            font: kcm.generalFont
> -        }
> -        FontWidget {
> -            label: i18n("Fixed width:")
> -            category: "fixedWidthFont"
> -            font: kcm.fixedWidthFont
> -        }
> -        FontWidget {
> -            label: i18n("Small:")
> -            category: "smallFont"
> -            font: kcm.smallFont
> -        }
> -        FontWidget {
> -            label: i18n("Toolbar:")
> -            category: "toolbarFont"
> -            font: kcm.toolbarFont
> -        }
> -        FontWidget {
> -            label: i18n("Menu:")
> -            category: "menuFont"
> -            font: kcm.menuFont
> -        }
> -        FontWidget {
> -            label: i18n("Window title:")
> -            category: "windowTitleFont"
> -            font: kcm.windowTitleFont
> -        }
> -        
> -        Kirigami.Separator {
> -            Kirigami.FormData.isSection: true
> -        }
> +        Kirigami.FormLayout {
> +            id: formLayout

Do we need a Layout.fillWidth here?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  no-more-warning-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22752

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190725/4070e325/attachment.html>