D22742: Show about distro KCM in System Settings' System Administration category
Nathaniel Graham
noreply at phabricator.kde.org
Thu Jul 25 18:21:42 BST 2019
ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
This is an alternative to D22728 <https://phabricator.kde.org/D22728>. It makes the System Information KCM appear in
System Settings' System Administration section.
Advantages over D22728 <https://phabricator.kde.org/D22728>:
- The information is more discoverable
- It automatically disappears if KInfoCenter is not installed or removed
- It requires no changes to SystemSettings' fragile codebase
Disadvantages:
- Since it doesn't open KInfoCenter or have a link to it, all the other information in KInfoCenter is not exposed
- If we do later want to adjust this KCM to have a button to open KInfoCenter when pushed, we'll hit https://bugs.kde.org/show_bug.cgi?id=410169 since the KCM will be already open in System Settings
TEST PLAN
F7096717: in systemsettings.png <https://phabricator.kde.org/F7096717>
REPOSITORY
R102 KInfoCenter
BRANCH
show-about-distro-kcm-in-systemsettings (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D22742
AFFECTED FILES
Modules/about-distro/src/about-distro.desktop
To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190725/b7a9119c/attachment.html>
More information about the Plasma-devel
mailing list