D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar
Jonathan Marten
noreply at phabricator.kde.org
Thu Jul 25 16:17:16 BST 2019
marten created this revision.
marten added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
marten requested review of this revision.
REVISION SUMMARY
Bug https://bugs.kde.org/show_bug.cgi?id=410190 describes the inconsistent virtual desktop numbering between the Switch Window popup and the taskbar Move To Desktop list. This patch fixes the Switch Window popup to use the more natural (to the user) 1-based desktop IDs.
According to virtualdesktopinfo.h, a desktop ID on Wayland is a QString while on X11 it is a uint. Therefore using toString() here for correct formatting of the desktop ID on both X11 and Wayland.
TEST PLAN
Built plasma-workspace with this change, observed correct and consistent desktop numbering in both these places. Not yet able to test on Wayland.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D22740
AFFECTED FILES
containmentactions/switchwindow/switch.cpp
To: marten, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190725/b57a6416/attachment-0001.html>
More information about the Plasma-devel
mailing list