D22735: Introduce ResultsModel with better data processing and filtering
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Thu Jul 25 15:33:03 BST 2019
apol added a comment.
LGTM overall
INLINE COMMENTS
> ResultsView.qml:94
>
> - if (runAutomatically) {
> - runCurrentIndex();
> + function reset() {
> + listView.currentIndex = 0;
Call it `resetView()`? Otherwise it seems like you're resetting the model again.
REPOSITORY
R112 Milou
REVISION DETAIL
https://phabricator.kde.org/D22735
To: broulik, #plasma
Cc: apol, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190725/801bdaed/attachment-0001.html>
More information about the Plasma-devel
mailing list