D22540: Port ResultDelegate to use PlasmaComponents 3.0

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Jul 25 01:15:19 BST 2019


apol marked 2 inline comments as done.
apol added inline comments.

INLINE COMMENTS

> broulik wrote in ResultDelegate.qml:142
> This should be a `Svg` from the Plasma Theme

There's no separator svg. you suggest creating a new one?

> broulik wrote in ResultDelegate.qml:231
> QQC2 tooltip stuff doesn't really work for KRunner because they're not separate windows :(
> 
> Also, don't use `ToolTip` attached property as it cannot respect the theme's delay settings

`QQC2 tooltip stuff doesn't really work for KRunner because they're not separate windows :(` it looks good to me.

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D22540

To: apol, #plasma
Cc: davidedmundson, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190725/cddf1f2a/attachment.html>


More information about the Plasma-devel mailing list