D22716: Add icons to Categories, Installed, and Sources globaldrawer entries
Dan Leinir Turthra Jensen
noreply at phabricator.kde.org
Wed Jul 24 14:38:24 BST 2019
leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.
REVISION SUMMARY
At some point, icons were removed from a number of entries in the global
drawer, but with the many other changes which have happened since then
this now leaves the sidebar looking somewhere between overly vacant and
broken (with some overweight toward the latter). This patch adds these
icons back in, as well as a couple of others, which results in a global
drawer which looks considerably more completely loaded.
This is furthermore based on feedback from the Plasma Mobile Todo[1] notes
entry, which at time of writing contains the following (amongst others):
Discover:
Global toolbar:
- Installed and Sources should have icons
- Categories should either have icons or be less indented
[1] https://notes.kde.org/p/plasma-mobile-todo
Parent Categories created by the category reader
TEST PLAN
See before without icons looks empty and just a tiny bit broken, and after
with icons included looks fully populated (screenshots incoming)
REPOSITORY
R134 Discover Software Store
BRANCH
more-globaldrawer-icons (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D22716
AFFECTED FILES
discover/qml/DiscoverDrawer.qml
discover/qml/DiscoverWindow.qml
libdiscover/Category/CategoriesReader.cpp
libdiscover/backends/KNSBackend/KNSBackend.cpp
To: leinir
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190724/5e591a11/attachment.html>
More information about the Plasma-devel
mailing list