D22613: kstart: Prevent crash when running without args

Aleix Pol Gonzalez noreply at phabricator.kde.org
Sun Jul 21 16:18:31 BST 2019


apol added a comment.


  LGTM otherwise

INLINE COMMENTS

> kstart.cpp:355
>    } else {
> -      if ( parser.positionalArguments().count() == 0 )
> +      if ( parser.positionalArguments().count() == 0 ) {
>            qCritical() << i18n("No command specified");

if ( parser.positionalArguments().isEmpty() ) {

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22613

To: tasossahanidis, davidedmundson
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190721/ef7ba636/attachment.html>


More information about the Plasma-devel mailing list