D22596: [MPRIS Data Engine] Ignore non-standards compliant players
Kai Uwe Broulik
noreply at phabricator.kde.org
Sat Jul 20 21:20:33 BST 2019
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Properties like `Identity`, `SupportedUriSchemes`, `SupportedMimeTypes` are mandatory. Ignore the player if it's clearly violating the spec.
TEST PLAN
Chrome's own unfinished mpris implementation no longer steals the show from p-b-i
VLC still works
Will probably hold off merging it until I have tested with some more players
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D22596
AFFECTED FILES
dataengines/mpris2/mpris2engine.cpp
To: broulik, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190720/35e9344d/attachment.html>
More information about the Plasma-devel
mailing list