D22533: [KCM] Slightly imptove tab bar's integration with frame
Nathaniel Graham
noreply at phabricator.kde.org
Thu Jul 18 18:34:27 BST 2019
ngraham created this revision.
ngraham added reviewers: drosca, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
We don't yet have a real QML tab widget (https://bugs.kde.org/show_bug.cgi?id=394296)
so we have to manufacture our own by combining a TabBar with a frame in which the
content sits.
This patch slightly improves the look and feel of our manufactured tab widget
by moving the tab portion down a bit so it overlaps the frame, which does a
better job of mimiching the QWidgets version. It's not perfect, but it's at
least no worse with all the themes I tried, and for some it looks better.
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
slightly-better-tab-bar (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D22533
AFFECTED FILES
src/kcm/package/contents/ui/main.qml
To: ngraham, drosca, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190718/e534348f/attachment-0001.html>
More information about the Plasma-devel
mailing list