D22509: [ComboBox] Set close policy to close on click outside instead of only outside parent

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Jul 17 14:15:09 BST 2019


broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Ensures clicking the `ComboBox` itself closes the popup as it does with widget `QComboBox`.
  While Qt documentation for `Popup` says that is the default, `QQuickComboBox` explicitly overwrites it to be `CloseOnPressOutsideParent` instead for whatever reason.
  For our usecase the `CloseOnPressOutside` behavior makes more sense.
  
  BUG: 408950

TEST PLAN
  - Opened QQC2 combobox, clicked on it again, it closed :)

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D22509

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190717/64df6a0b/attachment.html>


More information about the Plasma-devel mailing list