D22492: pull platforms/distributions dynamically out of the bugzilla api

Harald Sitter noreply at phabricator.kde.org
Tue Jul 16 16:17:28 BST 2019


sitter created this revision.
sitter added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this ensures that all known platforms are actually in the comobox and
  reduces the amount of string duplication.
  
  the new code gets the list of platforms from bugzilla and then either
  attempts to select the one which was auto-detected by systeminformation
  or recycle the one previously used.
  
  setup is now triggered in the constructor. loading from the api is still
  fairly cheap but even so takes longer than the hardcoded list, so
  loading this on aboutToShow is fairly unattractive at this point.
  
  the now useless members for combobox state tracking are gone entirely.
  
  BUG: 383530

TEST PLAN
  list gets loaded as expected
  list errors as expected when offline

REPOSITORY
  R871 DrKonqi

BRANCH
  distros

REVISION DETAIL
  https://phabricator.kde.org/D22492

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.h
  src/bugzillaintegration/ui/assistantpage_bugzilla_information.ui

To: sitter, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190716/34286c4c/attachment.html>


More information about the Plasma-devel mailing list