D22452: Fix text color in non-selected tabs in Firefox

[Nathaniel Graham]

ngraham added a comment.


  In D22452#495666 <https://phabricator.kde.org/D22452#495666>, @mthw wrote:
  
  > In D22452#495325 <https://phabricator.kde.org/D22452#495325>, @ngraham wrote:
  >
  > > Whether or not it's better is not relevant for this patch, which right now is only about fixing the text color. It's best not to mix multiple changes like this, unless you want to expand the patch in scope, in which case it should be re-titled accordingly.
  > >
  > > Still, I would recommend doing one change per patch, because it makes each one more likely to get in compared to patches with multiple changes (especially when any one of those individual changes may be controversial or require discussion).
  >
  >
  > If I did re-title and change the description, would this have a better chance of passing?
  
  
  Yes, but then you would still have to convince people that the other included color change is good as well.
  
  > The chage is so small (number of lines) that It probably wouldn't make sense to split it.
  
  It's not about number of lines; it's about how many distinct changes it introduces. Imagine a three-line patch that introduces three changes, where one is a bugfix and two of which are potentially controversial visual or behavioral changes. It's a small patch, but it would benefit from being split into three so the uncontroversial bugfix can be committed ASAP, without getting derailed by a discussion of the other issues.
  
  Does that make sense? If the problem here is that you don't know how to separate your bugfix from the visual change, I would encourage you to big into that a bit!

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D22452

To: mthw, #vdg, #breeze, ndavis, ngraham
Cc: cblack, ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190715/92030a4c/attachment.html>