D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> Main.qml:414
> +            id: logo
> +            visible: config.showdistrologo == "shown"
> +            source: config.distrologo

Why not just a bool?

> Main.qml:415
> +            visible: config.showdistrologo == "shown"
> +            source: config.distrologo
> +            anchors.horizontalCenter: parent.horizontalCenter

Also set a `sourceSize` and probably `asynchronous: true`

> Main.qml:421
> +            fillMode: Image.PreserveAspectFit
> +            height: units.largeSpacing * 8
> +            Behavior on opacity {

This is not what `spacing` is supposed to be used for. Try `units.gridUnit`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190715/c3a1d525/attachment-0001.html>