D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

Filip Fila noreply at phabricator.kde.org
Mon Jul 15 09:03:49 BST 2019


filipf added a comment.


  Looks better, in particular I like the approach with buttons for orientation because it saves the second or two of having to remember what's clockwise or counter-clockwise.
  
  Only some minor things I noticed in the screenshots:
  
  - can the margins on the view area be increased so that it's in line with where the text begins (red is what I'd remove)?
  
  F7026173: image.png <https://phabricator.kde.org/F7026173>
  
  - for every form data label I'd add ":" at the end
  - in the case of sliders I would simply add the label to the slider, not the column layout

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190715/dce9c75c/attachment.html>


More information about the Plasma-devel mailing list