D22457: Make it possible to show the QR of a network connection

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> ShowQR.qml:25
> +import org.kde.kirigami 2.3 as Kirigami
> +import org.kde.prison 1.0 as Prison
> +

Add this as `RUNTIME` Cmake dependency

> ShowQR.qml:27
> +
> +Window
> +{

Can you instad do a `StackView` and show the barcode inside the applet like Klipper does it? This would make it more consistent.

> handler.cpp:230
> +
> +    KNotification *notification = new KNotification("WifiQR", KNotification::CloseOnTimeout);
> +    notification->setComponentName("networkmanagement");

What does this do?

> handler.h:72
> +
> +    QString wifiCode(const QString& connection, const QString& specificObject) const;
> +

Docs, coding style.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22457

To: apol, #plasma, jgrulich
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190715/c22d590a/attachment.html>