D22467: Make captive portal notification persistent but low priority

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
ngraham requested review of this revision.

REVISION SUMMARY
  The captive portal notification is something that shouldn't time out; when it
  becomes visible, it's something the user needs to interact with. I had a
  frustrating experience just now trying and failing to click on it before it timed
  out.
  
  At the same time, once it's interacted with (either by closing it or clicking the
  "Log in" button, there's no need for it to appear in the history, as its history
  item is both non-informative and non-interactive.
  
  Accordingly, this patch makes the captive portal notification both persistent and
  low urgency (so it doesn't appear in the history).
  
  A similar thing has already been done for Discover in D22429 <https://phabricator.kde.org/D22429>.

TEST PLAN
  Connected to the in-flight wifi network  on the plane I'm on right now
  Captive Portal notification was persistent and didn't show up in the history
  after dismissed or logged into via the button on the notification pop-up

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  persistent-captive-portal-notification (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22467

AFFECTED FILES
  kded/networkmanagement.notifyrc
  kded/portalmonitor.cpp

To: ngraham, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190715/c2237063/attachment.html>