D22333: Move Solid::Device::listFromQuery calls to a separate thread
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Sat Jul 13 02:02:00 BST 2019
bruns added a comment.
In D22333#494810 <https://phabricator.kde.org/D22333#494810>, @apol wrote:
> In D22333#494774 <https://phabricator.kde.org/D22333#494774>, @bruns wrote:
>
> > Also, the code is calling non-threadsafe code from multiple threads now (e.g. once from each the two dataengines helper threads). Each one will call the udisks2 `Manager::deviceCache()` method.
>
>
> There's a Backend per-thread and deviceCache is not static so each thread will call its own.
Sorry, but you are wrong, look for
`Q_GLOBAL_STATIC(Solid::DeviceManagerStorage, globalDeviceStorage)`
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D22333
To: apol, #plasma, davidedmundson, bruns
Cc: bruns, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190713/71a8676f/attachment-0001.html>
More information about the Plasma-devel
mailing list