D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

David Redondo noreply at phabricator.kde.org
Fri Jul 12 13:48:19 BST 2019


davidre updated this revision to Diff 61648.
davidre added a comment.


  - Only restore wallpaper on startup
  - Guard against empty path
  
  I couldn't understand why this was being called with an empty string so I just guard 
  against it at the call site. Maybe this also helps @ngrahams crash but I still don't know
  where it is coming from.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=61335&id=61648

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190712/2ee42cea/attachment-0001.html>


More information about the Plasma-devel mailing list