D22333: Move Solid::Device::listFromQuery calls to a separate thread

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Jul 12 00:15:10 BST 2019


apol added a comment.


  In D22333#494389 <https://phabricator.kde.org/D22333#494389>, @bruns wrote:
  
  > Again, where is it blocking? Which backend?
  
  
  udisks2 mainly, but every backend can block by its virtue.
  
  > listFromQuery can be replaced by an asynchronous "enumerate(predicate)" call which uses the existing DeviceAdded signal. This would also remove the inherent race between the listFromQuery and DeviceAdded/DeviceRemoved.
  
  I've looked into changes that could be done to solid to improve this, nothing felt like a good step forward. This approach works, makes sense and shows results.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22333

To: apol, #plasma, davidedmundson, bruns
Cc: bruns, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190711/b3e854f8/attachment.html>


More information about the Plasma-devel mailing list