D22397: [Fonts KCM] Alter DPI only on explicit user interaction
Kai Uwe Broulik
noreply at phabricator.kde.org
Thu Jul 11 14:12:14 BST 2019
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
The settings are loaded after the QML is created, and once it is loaded, it becomes indeterministic which property (checkbox checked or spinbox value) is re-evaluated first and the `Binding` ends up resetting the config.
TEST PLAN
Opened Fonts KCM, DPI 192 was properly shown, changed some other font settings, my DPI did not change
Changed font DPI, worked fine. Checking and unchecking also works fine. When unchecking it resets the value to 96
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D22397
AFFECTED FILES
kcms/fonts/package/contents/ui/main.qml
To: broulik, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190711/7014f8fb/attachment.html>
More information about the Plasma-devel
mailing list